-
-
Notifications
You must be signed in to change notification settings - Fork 34k
Open
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
Description
LGTM - I do have more meta comments about existing patterns in the workflow file though:
- I'm wondering if
x86_64-pc-windows-msvc/msvc-free-threadingwould be more consistent with the triple/compiler pattern. - It might be a bit more robust to use a matrix variable here like
free-threading: true? If we add more FT variants later, this could get a bit hairy.
Not a problem to solve in this PR since both of these are leveraging existing patterns but maybe some futureproofing we should consider.
Originally posted by @savannahostrowski in #144550 (review)
Linked PRs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)