Skip to content

Adding Internet stuff. WebSocket is now apart of CNE.#520

Draft
ItsLJcool wants to merge 30 commits intoCodenameCrew:mainfrom
ItsLJcool:internet-utils
Draft

Adding Internet stuff. WebSocket is now apart of CNE.#520
ItsLJcool wants to merge 30 commits intoCodenameCrew:mainfrom
ItsLJcool:internet-utils

Conversation

@ItsLJcool
Copy link
Contributor

@ItsLJcool ItsLJcool commented Jan 4, 2025

No description provided.

@ItsLJcool
Added WebSocketUtil (and intenet folder)
02acada 
Planning on adding more stuff to it.
@ItsLJcool
WebSocketUtil document
b8d3132
@ItsLJcool
Added the WebSockets and made internet lib
4a8af03 
Hi you Auto Action Download users!
<r>I can make your text red<r>

pretty cool right?

Human... I remember your <b>Commit History<b>
@ItsLJcool
added "hx.ws" as an import (wont work neo but ok)
ddf1a48
@ItsLJcool
fixed indentation
294fe6b
@ItsLJcool
Fixed some issues
f1e8d97
@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 4, 2025

Uh not done witht his yet actually, lemme add smth rq

@NexIsDumb
Copy link
Member

NexIsDumb commented Jan 4, 2025

i can already see the degenerates making buttplus addons
i love it

@NexIsDumb
Copy link
Member

NexIsDumb commented Jan 4, 2025

BUTTPLUS😭

@r6915ee
Copy link
Contributor

r6915ee commented Jan 5, 2025

The addon that adds an explosion to the screen as a separate window (using NDLLs) by secretly using a WebSocket to download the GIF and use it:

@NexIsDumb
Copy link
Member

NexIsDumb commented Jan 5, 2025

codename streaming

@r6915ee
Copy link
Contributor

r6915ee commented Jan 5, 2025

truely

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025

aight who wanna help me with codename online

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

aight who wanna help me with codename online

Thats the entire reason why im adding this lol
I already made CNE Online but with this I can make it more efficent and better managed

@r6915ee
Copy link
Contributor

r6915ee commented Jan 5, 2025

the seventeen player experience

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

image
Committing code war crimes rn

@r6915ee
Copy link
Contributor

r6915ee commented Jan 5, 2025

the concatenation experience (GONE WRONG)

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025

image Committing code war crimes rn

what is wrong with u
i hope you burn /j

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

image Committing code war crimes rn

what is wrong with u i hope you burn /j

image
Updated :trollface:

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

wait im so smart chat hol up

@NeeEoo
Copy link
Contributor

NeeEoo commented Jan 5, 2025

use an array please, its more optimized

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025

aight who wanna help me with codename online

Thats the entire reason why im adding this lol I already made CNE Online but with this I can make it more efficent and better managed

can i help pleaseeeeeeeeee /hj

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

aight who wanna help me with codename online

Thats the entire reason why im adding this lol I already made CNE Online but with this I can make it more efficent and better managed

can i help pleaseeeeeeeeee /hj

What can you help with?

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025

aight who wanna help me with codename online

Thats the entire reason why im adding this lol I already made CNE Online but with this I can make it more efficent and better managed

can i help pleaseeeeeeeeee /hj

What can you help with?

i was joking, but kinda not cuz im just bored out of my mind rn

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

Fair, I do want some ppl to help with like assets / concepts and playtesting

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025 •
edited
Loading

Fair, I do want some ppl to help with like assets / concepts and playtesting

i can kinda draw, i can concept
and playtesting is playtesting lol
(also got a linux server running in my basement lmao)

@r6915ee
Copy link
Contributor

r6915ee commented Jan 5, 2025

Fair, I do want some ppl to help with like assets / concepts and playtesting

I mean, I am able to playtest most of the time if necessary.

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 5, 2025

Fair, I do want some ppl to help with like assets / concepts and playtesting

i can kinda draw, i can concept and playtesting is playtesting lol (also got a linux server running in my basement lmao)

Wait you do??
peak what would I pay a month?

@NeeEoo
Copy link
Contributor

NeeEoo commented Jan 5, 2025

i think 500$ per hour would be good for them

@TechnikTil
Copy link
Contributor

TechnikTil commented Jan 5, 2025

Fair, I do want some ppl to help with like assets / concepts and playtesting

i can kinda draw, i can concept and playtesting is playtesting lol (also got a linux server running in my basement lmao)

Wait you do?? peak what would I pay a month?

$10/month max, i could settle for $5
just give me like 2 weeks to upgrade specs

@NexIsDumb
Copy link
Member

NexIsDumb commented Jan 8, 2025

Imma also make this as a draft till its done

@NexIsDumb NexIsDumb marked this pull request as draft January 8, 2025 20:23
@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 8, 2025

yeah couldn't figure out how to change it lmao

@ItsLJcool
closeOnError is default since you can handle your errors by default.
a5bb1fc 
Basically the Server Template is done, and so I think WebSocket's are ready to be put into CNE.
@ItsLJcool ItsLJcool marked this pull request as ready for review January 10, 2025 08:16
@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 10, 2025

Server Template for the WebSocket:

https://github.com/ItsLJcool/WebSocket-Server-Template-for-CNE

@NeeEoo
Copy link
Contributor

NeeEoo commented Jan 11, 2025

Disable all async stuff for now, but keep the toggle

@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Jan 11, 2025

Disable all async stuff for now, but keep the toggle
👍

@NeeEoo NeeEoo added the status:planned This is planned to happen label Jan 11, 2025
NeeEoo
NeeEoo reviewed Mar 1, 2025
View reviewed changes
source/funkin/backend/system/net/WebSocketUtil.hx
Comment on lines +239 to +241
var _data = null;
if (data is WebSocketPacket) _data = data.toString();
else _data = data;
Copy link
Contributor

@NeeEoo NeeEoo Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give data and _data a type

@crowplexus crowplexus added the type:enhancement New feature or request label Jun 30, 2025
@crowplexus
Copy link
Member

crowplexus commented Jun 30, 2025

this KINDA has merge conflicts yk… rn at least… would be cool if u fixed (if you still wanna add this, that is)…

@FuroYT
Copy link
Member

FuroYT commented Jun 30, 2025

this KINDA has merge conflicts yk… rn at least… would be cool if u fixed (if you still wanna add this, that is)…

I think its unfinished iirc

@Raltyro
Copy link
Member

Raltyro commented Aug 9, 2025

please finish this... someone...

@ItsLJcool ItsLJcool marked this pull request as draft October 26, 2025 08:21
@ItsLJcool
Copy link
Contributor Author

ItsLJcool commented Oct 26, 2025

Deprechating this as its old asf

Planning on remaking it rn :trollface:

@MRK2009
Copy link
Contributor

MRK2009 commented Nov 17, 2025

Bruh

@Raltyro
Copy link
Member

Raltyro commented Nov 18, 2025

bruh

2 similar comments
@TechnikTil
Copy link
Contributor

TechnikTil commented Nov 18, 2025

bruh

@r6915ee
Copy link
Contributor

r6915ee commented Nov 18, 2025

bruh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NeeEoo NeeEoo NeeEoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:planned This is planned to happen type:enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ItsLJcool @NexIsDumb @r6915ee @TechnikTil @NeeEoo @crowplexus @FuroYT @Raltyro @MRK2009