Backend token/struct API for AbstractFFTs#323
Draft
nHackel wants to merge 2 commits intoJuliaMath:masterfrom
Draft
Backend token/struct API for AbstractFFTs#323nHackel wants to merge 2 commits intoJuliaMath:masterfrom
nHackel wants to merge 2 commits intoJuliaMath:masterfrom
Conversation
Inference is currently broken for plan_x without a provided backend. Loading multiple FFT backends will also break this. However, function calls with a provided backend should be type-stable
Author
|
Here is a version of the backend variant which solely relies on the backend token and thus results in a breaking change. To not spam PRs, I created a PR in my fork for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a backend token api as discussed in this AbstractFFTs PR. It would be great if we could keep the main discussion on the general design in the AbstractFFT PR.
An additional FFTW specific consideration is the question if the AbstractFFTs PR is accepted, do we want to extend it to the
plan_xfunctions which are not defined in AbstractFFTs, such as the r2r or the dct.Also currently the
@inferedtests fail for the high-level interface, because the infered return type is a union of two plans. I haven't quite found a solution to that yet. In the setting that multiple FFT backends are loaded, this would be even "worse"/instable.