Open
Conversation
Contributor
torch-ray
commented
Sep 25, 2021
torch-ray
commented
- MainViewModel 에서 LoginManager 객체 및 역할 분리
- LoginManagerType Protocol 생성
- LoginResult struct 생성
Contributor
Author
|
수정 시작했습니다. 아직 Merge 단계는 아닙니다 ㅎㅎ |
eeeesong
reviewed
Sep 25, 2021
| struct LoginResult { | ||
| var gameVC: UIViewController? | ||
| var uuid: String? | ||
| } |
Collaborator
There was a problem hiding this comment.
타입 만들어서 리턴하는 방향성 아주 좋다고 생각합니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.