Open
Conversation
ESLint was correctly identifying that the final if statement was unnecessary since all other cases (allow, warn, error) return early. At this point in the code, conflictBehavior must be 'replace'.
Member
|
my refactors are too frequent resulting in merge conflicts 😭. This is a great idea though and I was thinking about it myself. If you rebase, we'll get this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR implements hotkey conflict detection with configurable behavior strategies, addressing the "Warn/error on conflicting shortcuts (TBD)" roadmap item from the README.
Motivation:
When multiple components or modules register the same hotkey, developers need control over how these conflicts are handled. Without this feature, duplicate registrations silently coexist, which can lead to unexpected behavior and difficult debugging.
Implementation:
ConflictBehaviortype with 4 strategies:'warn','error','replace','allow'conflictBehavioroption toHotkeyOptions(defaults to'warn'for safety)#findConflictingRegistration()and#handleConflict()private methodsno-unnecessary-conditionwarningUsage:
✅ Checklist
🚀 Release Impact