Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions maths/factorial.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
"""
Factorial of a positive integer -- https://en.wikipedia.org/wiki/Factorial
"""
"""FACTORIAL."""


def factorial(number: int) -> int:
Expand All @@ -27,16 +25,19 @@ def factorial(number: int) -> int:
"""
if number != int(number):
raise ValueError("factorial() only accepts integral values")

if number < 0:
raise ValueError("factorial() not defined for negative values")
value = 1

for i in range(1, number + 1):
value *= i
return value


def factorial_recursive(n: int) -> int:
def factorial_recursive(number: int) -> int:
"""

Calculate the factorial of a positive integer
https://en.wikipedia.org/wiki/Factorial

Expand All @@ -51,18 +52,21 @@ def factorial_recursive(n: int) -> int:
Traceback (most recent call last):
...
ValueError: factorial() not defined for negative values

"""
if not isinstance(n, int):

if not isinstance(number, int):
raise ValueError("factorial() only accepts integral values")
if n < 0:

if number < 0:
raise ValueError("factorial() not defined for negative values")
return 1 if n in {0, 1} else n * factorial_recursive(n - 1)
return 1 if number in {0, 1} else number * factorial_recursive(number - 1)


if __name__ == "__main__":
import doctest

doctest.testmod()

n = int(input("Enter a positive integer: ").strip() or 0)
print(f"factorial{n} is {factorial(n)}")
number = int(input("Enter a positive integer: ").strip() or 0)
print(f"factorial{number} is {factorial(number)}")
Loading