Include subject count in error message#300
Open
martincostello wants to merge 1 commit intoactions:mainfrom
Open
Include subject count in error message#300martincostello wants to merge 1 commit intoactions:mainfrom
martincostello wants to merge 1 commit intoactions:mainfrom
Conversation
When too many subjects are specified, include the number in the error message.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error message when the subject count exceeds the maximum limit by including the actual number of subjects provided.
- Enhanced error message to display both the maximum allowed subjects and the actual count provided
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/subject.ts | Updated error message to include actual subject count |
| dist/index.js | Compiled/transpiled version of the source change |
| tests/main.test.ts | Updated test expectations to match the new error message format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When too many subjects are specified, include the number in the error message.
This makes it easier for the user to determine are they just over the limit, or are they way over the 1024 limit.