Refactor actionUrl function to support customizable base URI#177
Open
NamrathShetty wants to merge 1 commit intoactions:mainfrom
Open
Refactor actionUrl function to support customizable base URI#177NamrathShetty wants to merge 1 commit intoactions:mainfrom
NamrathShetty wants to merge 1 commit intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the actionUrl function to support a customizable base URI, enabling the function to handle GitHub Enterprise Server (GHES) scenarios. Key changes include:
- Changing the actionUrl function signature to include a baseUri parameter.
- Normalizing the baseUri to ensure it ends with a forward slash.
- Removing the TODO comment now that the customization is implemented.
Comments suppressed due to low confidence (1)
languageservice/src/action.ts:70
- [nitpick] Consider renaming 'gitHubBaseUri' to 'normalizedBaseUri' to clearly indicate that this variable represents a normalized version of the base URI.
const gitHubBaseUri = baseUri.endsWith("/") ? baseUri : `${baseUri}/`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.