update spring boot, spring cloud, nacos client versions#4003
Open
szjerrywang wants to merge 1 commit intoalibaba:2023.xfrom
Open
update spring boot, spring cloud, nacos client versions#4003szjerrywang wants to merge 1 commit intoalibaba:2023.xfrom
szjerrywang wants to merge 1 commit intoalibaba:2023.xfrom
Conversation
|
|
yuluo-yx
approved these changes
Jul 3, 2025
| <suppress files=".java" checks="AvoidStarImport" /> | ||
| <suppress files=".java" checks="RegexpSinglelineJava" /> | ||
| <suppress files=".*" checks="LineLength" /> | ||
| </suppressions> No newline at end of file |
Collaborator
There was a problem hiding this comment.
| <seata.version>2.3.0</seata.version> | ||
| <!-- Apache RocketMQ --> | ||
| <rocketmq.version>5.3.1</rocketmq.version> | ||
| <rocketmq.version>5.3.3</rocketmq.version> |
Collaborator
There was a problem hiding this comment.
hi, 在升级时有运行项目中的 example 例子吗？确保 example 正常运行且符合预期很有必要
| } | ||
|
|
||
| @Override | ||
| public void fuzzyWatch(String groupNamePattern, FuzzyWatchEventWatcher listener) throws NacosException { |
Collaborator
There was a problem hiding this comment.
这里文件的作用是什么？似乎它时一个空的 Mock 文件？
| @@ -0,0 +1,62 @@ | |||
| /* | |||
| * Copyright 2013-2023 the original author or authors. | |||
| import org.springframework.http.HttpHeaders; | ||
| import org.springframework.http.HttpInputMessage; | ||
| import org.springframework.util.Assert; | ||
|
|
| /** | ||
| * Using by {@link SentinelRestTemplate} and {@link SentinelProtectInterceptor}. | ||
| * | ||
| * @author <a href="mailto:fangjian0423@gmail.com">Jim</a> |
| } | ||
|
|
||
| @Override | ||
| public HttpHeaders getHeaders() { |
Collaborator
There was a problem hiding this comment.
hi， 我看到这里是移到了 BaseHttpInputMessage 类中吗？
yuluo-yx
added
waiting-for-feedback
Collaborator
|
hi @szjerrywang 另外，我们有必要集成此 https://github.com/alibaba/spring-cloud-alibaba/pull/3929/files 变更吗？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
To support spring boot 3.5.0 and spring cloud 2025.0.0 dependencies.
Does this pull request fix one issue?
Describe how you did it
Update dependencies versions, fix some compilation errors.
Describe how to verify it
mvn install is done successfully.
Special notes for reviews