fix: replace CMAKE_SOURCE_DIR with CMAKE_CURRENT_SOURCE_DIR#16287
fix: replace CMAKE_SOURCE_DIR with CMAKE_CURRENT_SOURCE_DIR#16287marfvr wants to merge 1 commit intoargotorg:developfrom
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
|
Hi @marfvr, OSX and Arch builds are failing. Are you planning on continuing work on this? |
|
Hi @nikola-matic, thank you for your reply. Yes, I am willing to work on this PR (not immediately, though), as long as it is considered a good change proposal for the project. |
|
We already have an old pending PR for this: #15539. We should close one of them. |
|
Here's the comment I made the last time @matheusaaguiar asked me about that other PR. I guess I should have just posted it there. It's also still relevant here:
|
|
@cameel you are right with your comment, another one is |
This PR replaces occurrences of
CMAKE_SOURCE_DIRin the CMake configuration file withCMAKE_CURRENT_SOURCE_DIR. This change would allow the project to be usable as a CMake dependency for other CMake projects.