Rewrite to a sphinx project and use unified theme

[Cadair]

You can see a preview of this here: https://astropy-org--698.org.readthedocs.build/

Fun things to checkout:

• light and dark themes
• the search!!

I think this is now ready for review, but please confine review to the diff in this PR. i.e. not the theme which should be reviewed here: astropy/astropy-sphinx-theme#48

---

HTML Pages left to port:

• announcements/*.html
• contribute.html
• credits.html
• team.html
• paper1_10k_citations.html

Todo before merge:

• Find someone with power to move the astropy.org domain to RTD
• Add back Google Analytics, and start a discussion somewhere about improvements later
• Merge theme PR and release astropy-sphinx-theme

Other potential improvements:

• Use intersphinx for all links to core documentation
• See if we can generate a dark theme variant of the home page background

[Cadair]

I'll keep a list of things I think we could tidy up here as I go along:

• We should get rid of all the affiliated package javascript and have sphinx just do all the page gen on build. Then cronjob the site to rebuild each day or week or something.
• The Copy bibtex js on the citation page inlines all the bibtex which is just horrible, we should have sphinx read that in from somewhere sane. What is the canonical source of the citation bibtex?
• The javascript for the team page should all be removed and replaced with build-time Python code.

[pllim]

You will have to pull this change in too after it is merged. FYI

• Filter out astropy core package from pyOpenSci Affiliated listing #699

[Cadair]

@astropy/astropy-website-maintainers This is now ready for review.

[Cadair]

We should probably cut a release of astropy-sphinx-theme before merging this PR 😉

[pllim]

Can you pls cross link PR from that branch here for future reference? Thanks!

[Cadair]

It's in the PR description above.

[pllim]

Oh right, nevermind. We cannot merge until this is resolved. I better block merge given the approval.

[pllim]

This is now ready for review

Shouldn't I wait for you to resolve #698 (comment) first?

[Cadair]

This is now ready for review

Shouldn't I wait for you to resolve #698 (comment) first?

No, I don't think so. This PR is not about the theme it's about rewriting the astropy.org site to use sphinx. Comments about the theme should go on the theme PR.

[hamogu]

Now for the record: I'm not a maintainer of this repro because I have deep experience with web development, it's because we used to manually update the list of affiliated packages in this repro and I was the affiliated package editor at the time (and are again now, though we know how've a difference mechanism).
@eteq is the person who usually reviews changes like this.

That said, I'll have a look as soon as I can.

[hamogu]

Most of the changes are pretty straightforward changes for html->rst. I'm not saying that to diminish @Cadair 's work (I know it's still a lot of work to do that, but it's not conceptually hard), just to say that the review is basically "it works" and there is no need to review every changed line, because we would not want to include any changes in the wording of individual pages here anyway.
Otherwise, it's a pretty standard setup and I see no problems with it.

[hamogu]

Not really important here, since this is just a comment anyway, but I think most modern browsers now refuse to load any local file for security - for testing locally you'll a local web server running for all or most of them.

[Cadair]

yeah this comment is pretty old 😆

I'd like to purge this entire file of js if I have the time.

[pllim]

You have to resolve conflict to pick up #699 . Thanks!

[Cadair]

Merged in main

[pllim]

Hmm something is wrong.

• https://output.circle-artifacts.com/output/job/c54facb7-fa2f-420c-a71e-145a7dba6799/artifacts/0/html/index.html text is hard to read in dark mode
• https://output.circle-artifacts.com/output/job/c54facb7-fa2f-420c-a71e-145a7dba6799/artifacts/0/html/affiliated/index.html#affiliated-packages-registry is broken

[Cadair]

Looks like that's a circleci problem, the way that circleci previews somethings doesn't really work properly. If you look at the RTD preview it seems to work.

[pllim]

Thanks for the clarification. I hope you are right...

[pllim]

So this is good to merge or are we waiting on something else?

[pllim]

Can you please add comment to explain what this is for, for future reference?

[pllim]

Also... Don't we also use some sort of banner mechanism here that "talks" with astropy cord RTD, like when we announced the 10k citation stuff. Would that still work?

[pllim]

Oh right, nevermind. We cannot merge until this is resolved. I better block merge given the approval.

[Cadair]

So this is good to merge or are we waiting on something else?

There's a todo list in the OP, but mostly it's blocked on people reviewing / approving / arguing about colours on the theme PR.

[pllim]

Waiting for sunpy theme release

[Cadair]

Also... Don't we also use some sort of banner mechanism here that "talks" with astropy cord RTD, like when we announced the 10k citation stuff. Would that still work?

Yes, but I should actually make this site display the banner if it's active!

[Cadair]

Oh the other reason this shouldn't be merged at the moment is that it would break astropy.org in its current state. We need to figure out how to do the RTD migration, which needs someone to make (adopt?) the RTD project with an official hat on, and then to know who has the DNS power.

[pllim]

RTD migration

I have the power if CoCo7 let me.

DNS power

You have to hunt down @eteq