AXON-1600: Unable to stop response when "Rate limit exceeded"#1476
AXON-1600: Unable to stop response when "Rate limit exceeded"#1476jwang19-atlassian wants to merge 1 commit intomainfrom
Conversation
|
Is there any indication that this issue is caused by our code? |
|
|
||
| while (replayInProgress) { | ||
| // Check for cancellation during replay | ||
| if (this.pendingCancellation) { |
There was a problem hiding this comment.
I'm concerned about this logic.
You are setting pending cancellation to false when Rovo Dev didn't yet confirm the cancellation.
Which means, you will allow the user to send a new prompt, which is going to fail because there is another prompt being generated (since cancellation didn't happen yet).
The existing logic is blocking the user from sending a new prompt, which is intentional.
Also, even closing the socket with Rovo Dev doesn't result in a cancellation. Rovo Dev can still generate the response when the socket is disconnected.
Moreover, the cancellation API can return a failure. In a perfect world it shouldn't, but it's possible.
In that case we want to surface the error to the user and let them know that the stream is still happening.
What Is This Change?
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: