Add support for tsconfig.json files that have an extends property#1313
Open
Jtupiter wants to merge 1 commit intodanger:mainfrom
Open
Add support for tsconfig.json files that have an extends property#1313Jtupiter wants to merge 1 commit intodanger:mainfrom
extends property#1313Jtupiter wants to merge 1 commit intodanger:mainfrom
Conversation
* Fix issue where dangerjs did not support extended tsconfigs * Add tests to verify extending tsconfigs
Member
|
Hi, I'm a little surprised by the failing tests here - do you have a sense of why it broke? |
Author
Yeah, I was confused by this. It's completely unrelated to my change and it passes locally. The failing snapshot also looks correct, which makes me think it has something to do with line endings. Will see if I can resolve this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Fixes issue #1283.
Following what was suggested in the issue to mimic what
ts-nodeis doing to resolve thetsconfig.jsonhere.Their method is quite a bit more complex since they need to resolve custom
ts-nodecompiler options.For our purposes, reading the config file using
ts.readConfigFileand then parsing it withts.parseJsonConfigFileContentproduces the expectedtsconfig.jsoneven when it extends another one.Tests
Added a test to confirm that danger resolves extended tsconfigs.