feat: ✨ add OCO_EMOJI_POSITION_BEFORE_DESCRIPTION #288
Open
ThomasSanson wants to merge 5 commits intodi-sukharev:devfrom
Open
feat: ✨ add OCO_EMOJI_POSITION_BEFORE_DESCRIPTION #288ThomasSanson wants to merge 5 commits intodi-sukharev:devfrom
ThomasSanson wants to merge 5 commits intodi-sukharev:devfrom
Conversation
…ION config key and implement its usage in prompts The new configuration key OCO_EMOJI_POSITION_BEFORE_DESCRIPTION has been added to allow users to specify the position of the GitMoji in the commit message. This provides flexibility for users who may have different preferences for the placement of the GitMoji. The prompts have been updated to reflect this new configuration option and will now generate commit messages according to the user's preference.
|
Stale pull request message |
# Conflicts: # out/cli.cjs # out/github-action.cjs # package-lock.json
… commit messages This update provides users with the ability to customize the placement of GitMoji in their commit messages. It includes examples and command line instructions for setting the GitMoji position either before the description or at the start of the commit message.
Author
|
@di-sukharev, may I kindly request that you assume responsibility for this pull request ? Indeed, it appears that each time you approve another pull request, it leads to git conflicts on this one. To prevent such occurrences, it seems prudent for you to manage this task, thereby facilitating a more autonomous and direct resolution of the issue. |
Author
|
Owner
|
Will manage when i have time ;) thank you
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @di-sukharev,
I have submitted this pull request wherein I have made several amendments to your opencommit project.
I have introduced a new configuration key
OCO_EMOJI_POSITION_BEFORE_DESCRIPTIONthat allows users to customise the position of the emoji within the commit message. This provides users with greater flexibility in formatting their commit messages.I have updated the instructions within
generateCommitMessageFromGitDiff.tsto reflect this new option.I have also updated the
README.mdfile to include instructions on how to utilise theOCO_EMOJI_POSITION_BEFORE_DESCRIPTIONconfiguration. This configuration allows users to determine where the GitMoji should be placed within the commit message.I have updated the assistant to accommodate the new
OCO_EMOJI_POSITION_BEFORE_DESCRIPTIONconfiguration. The assistant now generates commit messages based on the emoji position specified by the user.Lastly, I have updated the package version from 2.4.2 to 3.0.4 to reflect these new modifications and improvements.
I would like to emphasise that I have tested these modifications locally and everything appears to be functioning as expected.
The results are visible in the commit.
However, I would like to draw your attention to the fact that the documentation for contributing to the project is somewhat sparse. This could make access to contribution more challenging for new contributors. I believe it would be beneficial to enhance this aspect to facilitate community contribution.
Thank you for your time and consideration. I eagerly await your feedback on my pull request.
Close #219