Create etcd_dash_dash_help_2to_conf.bash.sh#1015
Create etcd_dash_dash_help_2to_conf.bash.sh#1015webdawg wants to merge 1 commit intoetcd-io:mainfrom
Conversation
please be gentle
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: webdawg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @webdawg. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
|
Also: this is the version of the script to create a config file. The one that belongs in /website should be the version that generates the output for configuration.md. They'd both be pretty similar -- or even one script with switches -- but that's what we need in this location. |
jberkus
left a comment
There was a problem hiding this comment.
Changes per prior comment.
|
@webdawg do you think you'll get back to this change? |
|
So I need to move this to scripts for the project then? This script will output an optional configuration file into the etcd project. I would / could create an additional script to take that output, and insert it into configuration.md - it would be easier to have a second script because the conf style config example that is outputted is a closer match to the configuration.md. How do I move this to a different project or do I start the pull request over? Also can someone remind me of how I get this as part of a build trigger? What about tests? |
|
Yes, you'll need to start a new PR because it'll be against /etcd-io/etcd. I'd recommend asking for help on adding it to build etc. on #sig-etcd channel, or the etcd-dev mailing list, or in the Etcd community meeting. |
please be gentle
related issue #903