docs: add missing logging flags and remove capnslog#1106
docs: add missing logging flags and remove capnslog#1106Mvrk08 wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
Hi @Mvrk08. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Just to bring the attention @ronaldngounou i raised a new pr for the same open for the review based on your last remarks in #1104 |
|
Curious why you raised a new PR? Ok I will review. |
|
I encountered some issues fixing the commit history/DCO sign-off on my previous attempt, so I opted to open a fresh PR to ensure the history was clean. |
|
/ok-to-test |
|
Before I start reviewing, could you please address the |
|
I see you are working on the issue. Don't forget to rebase and squash your commits commits into 1 commit once you are done addressing the lint issues. |
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
from
0f1f4ab to
5d1816a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mvrk08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mvrk08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
4 times, most recently
from
ceb835d to
b07f3c8
Compare
Updated all the things @ronaldngounou as you asked let me know if anything else . |
|
The changes in the PR don't achieve the intent of this issue. The changes are unrelated to |
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
2 times, most recently
from
b7415bd to
e952bb6
Compare
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
from
e952bb6 to
527dc7f
Compare
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
from
527dc7f to
3f157ad
Compare
Signed-off-by: mrmahi2003 <maahirchauhan20@icloud.com>
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
from
3f157ad to
60c517e
Compare
jberkus
left a comment
jberkus
left a comment
There was a problem hiding this comment.
Hey, some questions about changes in this PR that I don't quite understand.
| 'gone' // v2store is not maintained any longer. (planned default in v3.7) | ||
| ``` | ||
|
|
||
| ### Logging flags {#logging} |
There was a problem hiding this comment.
Is there a reason for moving the Logging section?
There was a problem hiding this comment.
That's not necessarily a blocker, but I don't understand the logic of the section move.
|
|
||
| {{% alert color="warning" %}} | ||
| <i class="fas fa-exclamation-triangle mr-1"></i> **Caution**: If you mix-and-match configuration options, then the following | ||
| <**Caution**: If you mix-and-match configuration options, then the following |
There was a problem hiding this comment.
Not clear on why you're removing the alert triangles as part of this update. How is that related to fixing the flags?
4 participants
Description :
This PR adds a new section for Logging flags to the configuration documentation. It documents the flags used for configuring the logger (zap), log levels, and rotation settings.
Changes included:
Added missing logging flags: --logger, --log-outputs, --log-level, --enable-log-rotation, and --log-rotation-config-json.
Build Fix: Updated the section header to ### Logging flags {#logging}. This adds an explicit anchor to fix the check-links failure in the Netlify build (the Quickstart guide links to #logging, which was previously missing).
Related Issue :
Fixes part of #1074