[GHSA-vg7j-7cwx-8wgw] Mongoose search injection vulnerability#6784
Open
ljharb wants to merge 1 commit intoljharb/advisory-improvement-6784from
Open
[GHSA-vg7j-7cwx-8wgw] Mongoose search injection vulnerability#6784ljharb wants to merge 1 commit intoljharb/advisory-improvement-6784from
ljharb wants to merge 1 commit intoljharb/advisory-improvement-6784from
Conversation
Author
|
same as #6769 |
There was a problem hiding this comment.
Pull request overview
This PR corrects the security advisory GHSA-vg7j-7cwx-8wgw for a Mongoose search injection vulnerability by updating the affected version range and adding a hyperlink reference to the related incomplete fix.
Changes:
- Updated the earliest affected version from "0" to "3.8.0" based on testing that confirmed versions before 3.8.0 are not vulnerable
- Added hyperlink to related CVE-2024-53900 advisory for context about the incomplete fix
- Updated the modified timestamp to reflect the correction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I can't find commit 29b1c35 in https://github.com/Automattic/mongoose. Also, https://www.npmjs.com/package/mongoose/v/3.8.0 was published in Oct 2013 so it can't have a commit from Nov 2013. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Versions 0.0.1 through 3.5.16 are unaffected by this vulnerability. The vulnerable match option for mongoose populate() was introduced in version 3.8.0 (commit 29b1c35 - Nov 2013). Earlier versions do not have this code path and cannot be exploited via nested
$whereinjection in populate match queries. Testing confirms the PoC does not trigger on versions before 3.8.0.