C# 14: [TEST ONLY] Simple lambda parameters with modifiers.#21285
Open
michaelnebel wants to merge 3 commits intogithub:mainfrom
Open
C# 14: [TEST ONLY] Simple lambda parameters with modifiers.#21285michaelnebel wants to merge 3 commits intogithub:mainfrom
michaelnebel wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for C# 14's new feature that allows modifiers on implicitly typed lambda parameters. Previously, modifiers could only be used with explicitly typed lambda parameters, but C# 14 extends this capability to implicitly typed parameters as well. The PR confirms that the CodeQL extractor and QL library support this feature without requiring any code changes.
Changes:
- Added new test file
LambdaParameterModifiers.cswith test cases for both explicitly and implicitly typed lambda parameters with various modifiers (ref, out, in, ref readonly, scoped ref, params) - Updated
ParameterModifiers.qlto include lambda parameters from the new test file - Regenerated
ParameterModifiers.expectedwith expected results for the new test cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/test/library-tests/parameters/LambdaParameterModifiers.cs | New test file containing 11 lambda expressions demonstrating both explicitly and implicitly typed lambda parameters with all supported modifiers |
| csharp/ql/test/library-tests/parameters/ParameterModifiers.ql | Extended TestParameter class to include lambda parameters from the new test file |
| csharp/ql/test/library-tests/parameters/ParameterModifiers.expected | Regenerated expected results file containing entries for the 11 new lambda parameters with their respective modifiers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add tests for modifiers for implicitly typed lambda parameters. Prior to C# 14, it was only possible to use modifiers for explicitly typed lambda parameters. The feature is described here.
It turns out that the extractor and QL library supports this out-of-the-box.