feat: add audio sample rate adjustment to built-in presets#33
Merged
bajankristof merged 1 commit intomainfrom Oct 14, 2025
Merged
feat: add audio sample rate adjustment to built-in presets#33bajankristof merged 1 commit intomainfrom
bajankristof merged 1 commit intomainfrom
Conversation
Refs: ARC-11095
There was a problem hiding this comment.
Pull Request Overview
This PR adds audio sample rate adjustment functionality to FFMPEG presets, similar to existing frame rate handling. It ensures audio is encoded at appropriate sample rates by setting a default of 48kHz and using the closest standard sample rate when input rates are lower than targets.
- Audio sample rate parameter added to all built-in presets with 48kHz default
- New audio sample rate adjustment logic implemented with standard rate fallbacks
- Comprehensive test coverage added for various audio sample rate scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/ffmpeg/command_args.rb | Implements audio sample rate adjustment logic with standard rates array |
| lib/ffmpeg/presets/h264.rb | Adds audio_sample_rate parameter to all H264 preset methods and class |
| lib/ffmpeg/presets/aac.rb | Adds audio_sample_rate parameter to AAC preset methods and class |
| lib/ffmpeg/presets/dash/h264.rb | Updates DASH H264 presets to pass audio_sample_rate parameter |
| lib/ffmpeg/presets/dash/aac.rb | Updates DASH AAC presets to pass audio_sample_rate parameter |
| spec/ffmpeg/command_args_spec.rb | Adds comprehensive test coverage for audio sample rate adjustment |
| lib/ffmpeg/version.rb | Version bump to 8.1.0-beta.4 |
| CHANGELOG | Documents the new audio sample rate features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kiskoza
approved these changes
Oct 13, 2025
kadirsaglam41
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: ARC-11095