fix: add null checks and correct API method for activity plugin#1781
Open
endavis wants to merge 1 commit intolowlighter:masterfrom
Open
fix: add null checks and correct API method for activity plugin#1781endavis wants to merge 1 commit intolowlighter:masterfrom
endavis wants to merge 1 commit intolowlighter:masterfrom
Conversation
This fixes two critical issues in the activity plugin: 1. **Null pointer errors with deleted/missing users** Added null checks before destructuring user objects in 6 event types: - CommitCommentEvent (line 56) - IssueCommentEvent (line 87) - IssuesEvent (line 98) - PullRequestEvent (line 122) - PullRequestReviewEvent (line 131) - PullRequestReviewCommentEvent (line 142) GitHub API returns events where user accounts have been deleted, causing "Cannot read properties of undefined (reading 'login')" errors. 2. **Incorrect REST API method** Changed from `rest.activity.listEventsForAuthenticatedUser()` to `rest.activity.listPublicEventsForUser()` on line 32. The listEventsForAuthenticatedUser method doesn't accept a username parameter and was causing API errors. **Impact**: Prevents "Unexpected error" messages in generated SVGs when processing activity feeds containing deleted user accounts or using the plugin with public event feeds. **Testing**: Verified with multiple users having deleted account interactions in their activity feed. No more TypeErrors or API errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two critical issues in the activity plugin:
Null pointer errors with deleted/missing users Added null checks before destructuring user objects in 6 event types:
GitHub API returns events where user accounts have been deleted, causing
"Cannot read properties of undefined (reading 'login')" errors.
Incorrect REST API method Changed from
rest.activity.listEventsForAuthenticatedUser()torest.activity.listPublicEventsForUser()on line 32.The listEventsForAuthenticatedUser method doesn't accept a username parameter and was causing API errors.
Impact: Prevents "Unexpected error" messages in generated SVGs when processing activity feeds containing deleted user accounts or using the plugin with public event feeds.
Testing: Verified with multiple users having deleted account interactions in their activity feed. No more TypeErrors or API errors.