runtime: Implement MVP support for block-based emptyDir#419
Draft
runtime: Implement MVP support for block-based emptyDir#419
Conversation
As csi-directvolume-kata will use raw file on the host as the backend of a virtio-blk block device, and it is treated as just a regular file, which cause runtime label it unsupported device type. To correct such case, this patch supports it. Another important factor related to the issue kata-containers#11296, as it said that, the Options with bind does cause it fail. But in my test with runtime-rs, it works well. So in this patch, I just remove the related Option assignment from the m.Option Fixes kata-containers#11296 Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
16fcf5d to
6e99628
Compare
Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-facing changes
Servicing changes
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] runtime_type = "io.containerd.kata.v2" privileged_without_host_devices = true + pod_annotations = ["io.katacontainers.volumes.emptydir_sizelimit.*"]Current gaps with final implementation
Bugs
Demo
Below you notice that the mount source is
ext4(instead ofvirtiofstoday) and the fs type isext4(instead ofoverlaytoday):