fix(mcp): use PLAYWRIGHT_MCP_CONFIG env var to load config file#39048
Open
w0lf69 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(mcp): use PLAYWRIGHT_MCP_CONFIG env var to load config file#39048w0lf69 wants to merge 1 commit intomicrosoft:mainfrom
w0lf69 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The PLAYWRIGHT_MCP_CONFIG environment variable is read by configFromEnv() but was never actually used to load the config file. This fix adds a fallback to use the env var when --config CLI option is not provided. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pavelfeldman
approved these changes
Jan 30, 2026
| options.caps = commaSeparatedList(process.env.PLAYWRIGHT_MCP_CAPS); | ||
| options.cdpEndpoint = envToString(process.env.PLAYWRIGHT_MCP_CDP_ENDPOINT); | ||
| options.cdpHeader = headerParser(process.env.PLAYWRIGHT_MCP_CDP_HEADERS, {}); | ||
| options.config = envToString(process.env.PLAYWRIGHT_MCP_CONFIG); |
Member
There was a problem hiding this comment.
It is happening, just a little too late. Remove this line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLAYWRIGHT_MCP_CONFIGenvironment variable is documented and read byconfigFromEnv()but was never used to actually load the config fileresolveCLIConfig()to use the env var when--configCLI option is not providedTest plan
PLAYWRIGHT_MCP_CONFIG=/path/to/config.jsonenvironment variablecontextOptions.extraHTTPHeadersandcontextOptions.userAgent)--configCLI flag still takes precedence over env var🤖 Generated with Claude Code