Start background update in Windows-less mode to avoid stealing focus#293054
Start background update in Windows-less mode to avoid stealing focus#293054
Conversation
dmitrivMS
added
install-update
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where background updates on Windows steal focus from the active VS Code window. The fix adds the windowsHide: true option to the spawn call that launches the background update installer.
Changes:
- Added
windowsHide: trueoption to the spawn options when starting the background update installer in Windows
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Inno setup is built as a GUI app /SUBSYSTEM:Windows, lets wait for a repro before proceeding :)
Will keep diggoing. |
| windowsVerbatimArguments: true, | ||
| windowsHide: true |
There was a problem hiding this comment.
Are we sure this is doing anything? nodejs/node#21825 (comment)
There was a problem hiding this comment.
I was only thinking of console vs not-console application, good call on the detached. From https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags?redirectedfrom=MSDN
CREATE_NO_WINDOW0x08000000 | The process is a console application that is being run without a console window. Therefore, the console handle for the application is not set.This flag is ignored if the application is not a console application, or if it is used with either CREATE_NEW_CONSOLE or DETACHED_PROCESS.
3 participants
Fixes #142543