Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses disposable lifecycle leaks by properly registering event subscriptions for cleanup. The changes ensure that IDisposable objects created from event subscriptions are either added to DisposableStores for later cleanup or converted to one-time listeners using Event.once().
Changes:
- Fixed event subscription leak in testingContentProvider by registering model.onWillDispose() to the DisposableStore
- Converted peek.onDidClose() to Event.once() in testingOutputPeek to prevent duplicate subscriptions
- Fixed picker event subscription leaks in mcpRegistry by adding onDidAccept and onDidHide listeners to the DisposableStore
- Fixed quickpick event subscription leaks in mcpCommandsAddConfiguration by adding event listeners to the DisposableStore
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/testing/common/testingContentProvider.ts | Registered model.onWillDispose() to DisposableStore to ensure cleanup when model is disposed |
| src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts | Converted peek.onDidClose() to Event.once() since the event only fires once per peek instance |
| src/vs/workbench/contrib/mcp/common/mcpRegistry.ts | Added picker.onDidAccept() and picker.onDidHide() subscriptions to DisposableStore for proper cleanup |
| src/vs/workbench/contrib/mcp/browser/mcpCommandsAddConfiguration.ts | Added quickpick event subscriptions to DisposableStore and fixed disposal order |
bpasero
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #293200