encoder: Encode instances of Number as numbers, not maps#271
encoder: Encode instances of Number as numbers, not maps#271FlorianDenis wants to merge 2 commits intomsgpack:mainfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 97.28% 97.19% -0.09%
==========================================
Files 17 17
Lines 1140 1142 +2
Branches 253 254 +1
==========================================
+ Hits 1109 1110 +1
- Misses 31 32 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Why do you use the |
|
I am not going to go too much into the details of my project because this is not the place, but it turns out that I have a need for representing a integer using an object instance rather than a primitive type, a need which My goal with this PR is merely to point out that
|
|
@gfx Any thoughts on the above? |
Make sure instances of
Numberas encoded as anumberinstead of amap.I am encountering this issue in my current project, I believe this is a more sensible default behavior
All tests pass.