Added support for dynamic properties in classes#340
Open
ntninja wants to merge 1 commit intoprototypejs:masterfrom
Open
Added support for dynamic properties in classes#340ntninja wants to merge 1 commit intoprototypejs:masterfrom
ntninja wants to merge 1 commit intoprototypejs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for calling
Class.addMethodsfor objects with dynamic properties.Important: Dynamic property support only works with IE>=9! That however is not a problem because you ditched support for IE<9 several years ago (#302).
A unit test has been added that demonstrates how this feature can be used, note however that the unit test only uses the
Object.definePropertysyntax and not the nativeget x() {...}/set x(y) {...}syntax since that would cause syntax errors in browsers that do not understand it.