Open
Conversation
|
|
Author
Collaborator
|
Hi @timmermansjoy 👋🏻 Can you accept the CLA? We won't be able to merge this PR without it. |
Author
|
@SkalskiP i see, just did yea |
SkalskiP
requested changes
Aug 11, 2025
supervision/video/utils.py
Outdated
|
|
||
| @classmethod | ||
| def from_video_path(cls, video_path: str, backend: str | None = None) -> VideoInfo: | ||
| from .core import Video |
Collaborator
There was a problem hiding this comment.
We should avoid placing imports inside methods whenever possible.
Author
There was a problem hiding this comment.
I agree, But this one is nececary to avoid circular imports since core also uses VideoInfo and we use Video here from core making it a circular import if we would import it at the top of the file
…ervision into video-refactor
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).
implementing feature request: #1929
List any dependencies that are required for this change.
pyav (optional)
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
There will be a google colabs provided when its ready for testing as requested in #1929 and there can also be extra unit tests added if needed
Any specific deployment considerations
Documentation should be updated to give information about how the new video class will work compared to the old stand-alone functions
Docs
still need to be done