feat: add generate from latest tag#372
Conversation
bbaeef1 to
b32d267
Compare
b32d267 to
4a08b31
Compare
|
this looks good, and would love this feature 👀 |
|
Is there a voting mechanism here? 👍 would also love this feature. |
|
for now I've ended up using https://github.com/mikepenz/release-changelog-builder-action to generate the proper changelogs. it's a really nice action. this is how my steps looks like if somebody just wants to copy paste it and don't spend too much time on it 😂 |
…tion-gh-release into feat/add-generateReleaseNotes Adopt the addition of `previous_tag` input from softprops#372 .
Adopt new `previous_tag` input from softprops#372.
|
@softprops is this a feature that you intend to add? As there is a considerable amount of 👍 on the issue for this feature I'm curious if we should wait or to find a workaround. |
|
@pocesar can you fix the merge conflict for the PR, I can include this feature for the next release. |
|
@softprops could we get this merged, since it appears to bring great value to all users with little to none added effort? 🙏🏼 |
|
@fdventura there is merge conflict needs to be addressed first. |
|
Paging @pocesar |
|
my PR is 81 commits behind main, maybe it won't be a simple rebase 😬 |
|
@pocesar any follow-up ? 🚀 |
|
This would be great for us since we use a monorepo with many different types of releases. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
… into feat/add-generateReleaseNotes Signed-off-by: Rui Chen <rui@chenrui.dev>
|
I think this PR is ready for merge, can someone on this thread test out this commit, 898f81b and see if it works for you? Thanks! |
… into feat/add-generateReleaseNotes Signed-off-by: Rui Chen <rui@chenrui.dev>
… into feat/add-generateReleaseNotes Signed-off-by: Rui Chen <rui@chenrui.dev>
|
(note to myself, need to redo the latest merge master commit again) |
|
I have tested with commit 4577br1 and see the following: Configuration from logs: I would expect the release notes to be generated for this release, similar to how they are generated through the UI (e.g. they begin with Instead, on the release notes of the release, I see: (This is the full content, 3 lines ending with When I generate the release notes for an equivalent release from github UI, they generate correctly (e.g. they begin with I do not have a |
|
@chenrui333, is there anything we can do to get this merged? It looks like the conversation sometimes gets lost, and then we have conflicts, no one's fault, just a timing problem. To get this merged, is resolving the conflicts and including test evidence in the PR enough? If that is the case, I'm happy to fork and redo this PR in my repo and provide a clean, tested PR. I just want to align before proceeding, so we don't spend time working on it and end up in the backlog. Appreciate any help! |
This allows
DETACHED HEADtags to properly generate the RELEASE notes.Otherwise it will always try to generate the full release notes from multiple tags