pytest fixtures: hg / git configurations to session scope#475
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 64.17% 64.52% +0.34%
==========================================
Files 40 40
Lines 3713 3721 +8
Branches 788 789 +1
==========================================
+ Hits 2383 2401 +18
+ Misses 793 782 -11
- Partials 537 538 +1 ☔ View full report in Codecov by Sentry. |
a68d632 to
3e4d41e
Compare
Fixed 2 errors:
- src/libvcs/pytest_plugin.py:
1 × RET504 (unnecessary-assign)
- tests/sync/test_svn.py:
1 × COM812 (missing-trailing-comma)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #474
Problem
Issue #472 requires session-scoped fixtures.
Currently, we use
set_home,gitconfig, andhgconfigtomonkeypatch.setenv$HOME, pointing it to a temporary directory with user-specific configuration files. This ensures all subsequentgitandhgcommands automatically load these configurations.However,
monkeypatch.setenvdoesn't work with function-scoped fixtures.Improvement
Changes
pytest fixtures: Session-scoped
hgconfigandgitconfigThese are now set by
set_hgconfigandset_gitconfig, which setHGRCPATHandGIT_CONFIG, instead of overridingHOME.