Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 84.45% 84.42% -0.04%
==========================================
Files 16 16
Lines 933 931 -2
Branches 137 137
==========================================
- Hits 788 786 -2
Misses 92 92
Partials 53 53 ☔ View full report in Codecov by Sentry. |
686a633 to
83bec5a
Compare
Fixed 5 errors:
- conftest.py:
2 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config.py:
1 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config_file.py:
2 × PT001 (pytest-fixture-incorrect-parentheses-style)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Git, Subversion, and Mercurial repositories are unnecessarily reinitialized for each test via libvcs' pytest plugin.
tmp_pathusingshutil.copytree(source).Improvement
Note
If run again, these may not work due to changes in fixture naming and behavior between versions, as well as modifications to how they are used in the pull request.
Changes
libvcs 0.30.1 -> 0.33.0
See also:
Appendix